[17:55:49] NASSP Logging has been started by thymo [17:56:04] Hehe [17:56:06] .mute [17:56:10] Test [17:56:12] .unmute [17:56:54] thewonderidiot: Don't know if you saw this in the backlog. [17:56:55] [16:58:11] <@Thymo> thewonderidiot: Am I supposed to be able to write to input channels from within the AGC? I could set an input bit by doing V21N10 [17:57:06] no [17:57:12] yaAGC is very liberal with channels right now [18:09:43] alright, I'm almost there with the TEMP lamp changes [18:09:53] we have a lot of DSKYs to update now lol [18:17:58] I have started coding the ASA, I just need to have a condition now that switches the heater over [18:18:32] you have started coding the ASA heating [18:18:48] pretty sure we already had an ASA before :D [18:22:12] Well started adding the extra stuff [18:22:23] So yes haha [18:22:30] I have both heaters in there now [18:24:14] Actually, I might be able to get away with leaving them both on Auto and just using the config [18:25:30] Hmm or not [18:25:44] I think I want the fast heater to heat it to 116, then the fine heater to bring it to 120 and hold it there [18:26:26] so use a small range aroun 116 for the fast heater and a small range around 120 for the fine heater [18:26:32] indy91: https://github.com/virtualagc/virtualagc/pull/1058 [18:26:46] awesome [18:26:53] Thats what i did, but I need the fine heater to be off until the fast heater turns off [18:27:02] oh, I see [18:27:07] Otherwise both would heat [18:27:17] if (lem != NULL) { [18:27:17] fastheater->WireTo(&lem->SCS_ASA_CB); [18:27:18] fineheater->WireTo(&lem->SCS_ASA_CB); [18:27:19] //lem->Panelsdk.AddHydraulic(&hsink); [18:27:19] //lem->Panelsdk.AddElectrical(&heater, false); [18:27:20] fastheater->Enable(); [18:27:20] fastheater->SetPumpAuto(); [18:27:22] fineheater->Enable(); [18:27:24] fineheater->SetPumpAuto(); [18:27:26] Thats where I am working [18:27:46] I already added the pointers and such [18:27:50] hmm [18:28:26] you are adding it like the IMU heater stuff, but that is a really messy way as well [18:28:46] Yeah [18:28:52] Have a better solution? [18:29:58] add the heaters in the config, give them to the ASA and handle all of this in ASA code [18:31:44] I can implement if you want [18:31:47] that* [18:32:18] Isnt that what I am doing? [18:33:09] This is all in ASA code [18:33:22] well, tanks for letting me know :D [18:33:26] thanks* [18:33:47] where in the ASA? [18:33:50] Haha well I just started working it where the heater code existed and that is in LEM_ASA [18:34:14] ah, in the Init function, I see [18:34:16] Yep [18:34:27] I thought you were adding it in lemsystems [18:34:40] Nah [18:34:46] the heater is already there, very good [18:34:56] Yeah I just simply added another [18:35:03] Named them appropriately [18:35:16] And thats where I am now [18:35:18] yeah, that should work [18:35:31] and then add the logic for the heaters at the beginning of the ASA timestep [18:35:54] Ok, and for the Init I should only enable the fast heater and not both [18:37:03] Lots of interesting comments in the timestep [18:37:07] I don't even know why the Enable function is necessary [18:37:33] Me either [18:37:42] having the 1 in the config should do that [18:37:50] As long as it has power [18:37:50] enabled is true by default [18:37:56] so that should be unnecessary [18:38:00] Ok [18:38:10] maybe it's really old code [18:38:30] Yeah could be, like all that commented out stuff similar to that found in the IMU [18:39:24] SetPumpAuto() is equally unnecessary [18:39:38] if you set the first parameter as 1 in the config then that gets used for the pump mode [18:39:42] and auto is 1 [18:41:47] also [18:41:48] hsink->isolation = 1.0; [18:41:55] best set that to something tiny already [18:42:31] 0.0000001 [18:43:23] Is that what you used for the IMU [18:43:58] yep [18:44:07] and it's used for many tanks in the CSM [18:44:39] Ok [18:45:00] Hmm now to decypher the heater power [18:45:51] So the heater uses 253W electricity [18:46:06] The ASA itself uses 41.1W [18:46:23] Where did that 74 in the comments come from I wonder [18:53:08] So is the imuheater enable not needed as well? [18:56:29] probably not [18:58:20] Should the heat load also go in the ASA stuff? [19:00:44] yes [19:02:48] I will PR what I have so far you know the heat load stuff better than I [19:04:04] I need to get the wattages for the heaters still in the config but my changes so far are up [19:04:58] Now here is a question, do we want to move heat from the ASA heat sink to the glycol like the IMU? [19:05:06] Or just put the heat load into the glycol [19:06:02] We can do the same thing as with the IMU just set the heat exchanger temp to 120 [19:06:14] That way it can reject additional heat [19:08:51] This is also a case where the heat load is handled by the primary and secondary systems [19:36:07] we probably want to do it like the IMU [19:36:36] I agree [19:36:45] I added those heatsinks and such to the config in my PR [19:36:58] heat exchangers rather [19:40:44] main advantage of this method is that we have a separate system that simulates the temperature (radiator), a heating system (boiler) and a cooling system (heatexchanger) [19:41:09] well, if the ASA does have something like the IMU blowers [19:41:24] and we don't need to do this for many systems anyway [19:41:33] It doesnt, so the heat exchangers should just transfer heat to glycol [19:41:49] only precise systems like IMU and ASA need a tight temperature control [19:41:52] For stability we can use the temperature setting to 120 [19:42:04] Otherwise it just constantly absorbs heat from the ASA [19:42:12] No blowers to move heat to the fluid [19:42:46] I guess there won't be much heat anyway, if the ASA only has heaters [19:42:58] and nothing to cool it [19:43:11] not an extra system for that at least [19:44:35] Well the glycol cools the ASA through cold rails [19:45:39] Just not an active system like the IMU [19:46:02] so still a heat exchanger [19:46:09] but a weaker one [19:46:10] The IMU blowers are necessary because of the air inside of the case [19:46:14] right [19:46:23] Yeah [19:46:29] Weaker heat exchangers for the ASA [19:46:38] which we can balance out with the fine heater [19:46:59] Can you help me try to figure out the heat/power loads in the systems handbook for that? [19:47:45] I see the power for the heater and for electric, but since that is maximum load I am assuming the heater is the fast heater [19:48:03] I dont know what the heat of the fine heater would be [19:49:31] yeah, it's not easy to find [19:50:17] LM Data Book would maybe help with this [19:51:51] Have a link handy? I dont think I have one locally [19:52:19] haha [19:52:25] I don't have one locally either [19:52:27] Never mind [19:52:30] or remotely [19:52:35] but I would like to :D [19:52:45] Ah damn this is mission rules [19:52:57] one of those documents in my top 10 list [19:53:02] I opened the pdf and say LM DATA book and got excited [19:55:01] haha [20:57:47] Hey I'm back. [20:58:21] thewonderidiot: Did you end up finding out what the TEMP light should be by default? [20:58:31] off, I think [20:58:42] there's a lot of conflicting stuff I need to work through [20:58:58] but I am pretty sure that if the AGC loses power, the CMC/LGC warning light will come on, and that is it [20:59:27] Seeing as the rest of the DSKY lights also go off I can assume TEMP will too. [21:00:09] Has Nik committed your changes already? [21:01:13] nope [21:01:30] it needs testing [21:44:58] Also one thing I stumbled upon is that if yaAGC is given /dev/null it will read it as an endless stream of XXALQ. :p [21:51:38] .mute [21:51:46] test123 [21:52:00] .unmute [21:57:20] Meeting ended by Thymo, total meeting length 14491 seconds