[13:10:14] NASSP Logging has been started by n7275 [13:10:16] hey [15:16:34] indy91 what document do those ATMDC commands come from? [15:43:46] morning! [15:49:39] hey Mike [16:03:50] hey guys [16:06:25] n7275, https://web.archive.org/web/20100519173159/http://ntrs.nasa.gov/archive/nasa/casi.ntrs.nasa.gov/19770080485_1977080485.pdf [16:11:04] nice! I did not have that one yet. [16:11:16] n7275, your PR looks good. SkylabMesh.h file seems pretty useless. Only has the "pragma once" and it hasn't even been added to the VS project files [16:11:43] the project file also has a new [16:11:46] Unicode [16:11:49] what is that for? [16:12:00] oh whoops, SkylabMesh.h [16:12:05] can be deleted [16:12:21] uhhh, that shouldnt be there [16:13:19] the animation code is all fine. Had you seen that the Vessel API has a class for easier handling animation states, AnimState? [16:13:45] But it wouldn't improve the code by much [16:14:02] more useful for things that change their states often [16:14:07] and not a deployment once [16:14:22] we use AnimState for e.g. mobile launcher service arms [16:14:40] if there is a more orbiter-idiomatic way I can change it [16:15:26] I would use it for anything that can move back and forth and isn't just deployed one time [16:15:34] ahh [16:15:38] is there any animation you implemented that can be reversed? [16:16:00] any deployment [16:16:04] probably not I guess [16:16:45] then there is really no advantage [16:17:03] with AnimState you usually have a timestep that runs the animations at the right speed [16:17:11] and then if you want to change the state of them you can just do [16:17:11] damperarmState.action = AnimState::CLOSING [16:17:12] My intent was to add a class to simulate the physical deployment velocity, that would internally set the animation state of the ATM and arrays [16:17:39] I think for this specific case your custom implementation is probably better than using AnimState [16:17:57] so all good, get rid of unused files and I will approve it haha [16:18:46] in your branch I finally noticed that there are docking targets [16:19:06] looks more like 45° though, right? Not 35° angle [16:19:27] the lower docking port might actually be at 45°, haven't found a source on that yet [16:24:27] my PR only has the axial docking port correct, didn't add the lower one [16:26:38] we may have some adjusting to do there [16:27:13] just as long as we don't move any meshgroups in the animations I'm happy :) [16:29:16] found something interesting in the Skylab Rescue mission requirements. Apparently you do dock at 45° rolled on the lower port, but then they would roll to 7.25° from there between soft dock and hard dock? [16:30:27] not sure what for [16:31:11] oh of course [16:31:14] SM RCS [16:31:24] that aligns the SM RCS quads with the Skylab axes [16:35:14] of course this doesn't help us at all, we only have one docked orientation at the moment. Second docking port, low priority :D [16:49:02] I think our docking code might need to improve a bit for that [16:49:05] eventually [16:49:29] I pushed the commit removing that file [17:01:05] what's with the unicode thing? I don't want to nitpick, just asking why VS even added it... [17:01:31] I know it builds, so I am not worried about that, I can just merge it [17:21:46] im not sure. VS shows multi-byte on my end which is extra odd [17:22:27] we can just put it in the "VS doing VS things" category then [17:22:33] it showed up when i rebased [17:23:06] which i had to do twice because i fetched but didnt pull [17:23:20] merged [18:15:45] after my PR is merged we should have eliminated all the major issues, at least all the ones that prevent is flying the mission properly from launch to docking [18:15:52] prevent us* [18:25:27] i can probably approve that later today [18:25:48] I can merge the ATM animation update into it [18:26:04] might help docking. [18:26:14] I did it with help of the Docking MFD [18:27:45] done [19:11:36] is the port in the right position axially? [19:21:14] the axial port? the x-axis coordinate? [19:21:23] I checked the number [19:21:32] it's the docking interface [19:21:42] so you used the right one [20:50:01] night!